Issue 479443002: Not used in production. Add InRecovery() method to QUIC send algorithm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 479443002: Not used in production. Add InRecovery() method to QUIC send algorithm (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)

Modified:
6 years, 4 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade

Base URL:
https://chromium.googlesource.com/chromium/src.git@Add_flag_to_enable_BBR_73146298

Project:
chromium

Visibility:
Public.

More Reviews

Description

Not used in production. Add InRecovery() method to QUIC send algorithm interface, and pass slow start bool to bandwidth recorder. We still want to generate bandwidth estimates while in slow start, and include this information in the STK proto. We also need to know when we are in recovery mode so we can avoid calculating estimates. Merge internal change: 73239536 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -15 lines)			Patch
M	net/quic/congestion_control/pacing_sender.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/congestion_control/pacing_sender.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/congestion_control/send_algorithm_interface.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	net/quic/quic_sustained_bandwidth_recorder.h	View	3 chunks	+10 lines, -0 lines	0 comments	Download
M	net/quic/quic_sustained_bandwidth_recorder.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_sustained_bandwidth_recorder_test.cc	View	4 chunks	+51 lines, -14 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages