Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2009)

Unified Diff: content/renderer/render_frame_proxy.cc

Issue 479403004: Re-enable SitePerProcessBrowserTest.CrossSiteIframe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disable the test on CrOS and Android. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_proxy.cc
diff --git a/content/renderer/render_frame_proxy.cc b/content/renderer/render_frame_proxy.cc
index 14670716dfee75ba73d6c658a4e90db05bc3f45d..ff16e41aa71aca85ba94d49f6b36690e63f5f13a 100644
--- a/content/renderer/render_frame_proxy.cc
+++ b/content/renderer/render_frame_proxy.cc
@@ -39,16 +39,10 @@ RenderFrameProxy* RenderFrameProxy::CreateProxyToReplaceFrame(
scoped_ptr<RenderFrameProxy> proxy(
new RenderFrameProxy(routing_id, frame_to_replace->GetRoutingID()));
- blink::WebRemoteFrame* web_frame = NULL;
- if (frame_to_replace->GetWebFrame()->parent() &&
- frame_to_replace->GetWebFrame()->parent()->isWebRemoteFrame()) {
- blink::WebRemoteFrame* parent_web_frame =
- frame_to_replace->GetWebFrame()->parent()->toWebRemoteFrame();
- web_frame = parent_web_frame->createRemoteChild("", proxy.get());
- } else {
- web_frame = blink::WebRemoteFrame::create(proxy.get());
- }
-
+ // When a RenderFrame is replaced by a RenderProxy, the WebRemoteFrame should
+ // always come from WebRemoteFrame::create and a call to WebFrame::swap must
+ // follow later.
+ blink::WebRemoteFrame* web_frame = blink::WebRemoteFrame::create(proxy.get());
proxy->Init(web_frame, frame_to_replace->render_view());
return proxy.release();
}
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698