chrome/browser/ui/cocoa/applescript/tab_applescript.mm - Issue 479403004: Re-enable SitePerProcessBrowserTest.CrossSiteIframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/applescript/tab_applescript.mm

Issue 479403004: Re-enable SitePerProcessBrowserTest.CrossSiteIframe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Disable the test on CrOS and Android. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/applescript/tab_applescript.mm

diff --git a/chrome/browser/ui/cocoa/applescript/tab_applescript.mm b/chrome/browser/ui/cocoa/applescript/tab_applescript.mm

index 17ee0e4a2b5b9c200b4bf5ee8897bf7a23ae7baa..3dec7e5ae9bb9b482a30c0c1a3d2387701232f20 100644

--- a/chrome/browser/ui/cocoa/applescript/tab_applescript.mm

+++ b/chrome/browser/ui/cocoa/applescript/tab_applescript.mm

@@ -208,15 +208,7 @@ void ResumeAppleEventAndSendReply(NSAppleEventManagerSuspensionID suspension_id,

}

- (void)handlesStopScriptCommand:(NSScriptCommand*)command {

- RenderViewHost* view = webContents_->GetRenderViewHost();

- if (!view) {

- // We tolerate Stop being called even before a view has been created.

- // So just log a warning instead of a NOTREACHED().

- DLOG(WARNING) << "Stop: no view for handle ";

- return;

- }

- view->Stop();

+ webContents_->Stop();

}

- (void)handlesPrintScriptCommand:(NSScriptCommand*)command {

« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.h » ('j') | no next file with comments »