Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6281)

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/key_sequence.js

Issue 479323002: Fix broken ChromeVox keyboard shortcuts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Proper fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/common/key_sequence.js
diff --git a/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js b/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js
index f0d09239368859bd972f98561228cba13285f3de..a377a03cf666ca4d2d04d0b11c24b0c1fb704aa3 100644
--- a/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js
+++ b/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js
@@ -247,6 +247,11 @@ cvox.KeySequence.prototype.rationalizeKeys_ = function() {
if (modifierKeyCombo.indexOf(metaKeyName) != -1) {
if (metaKeyName == 'Search') {
this.keys.searchKeyHeld[index] = false;
+ // TODO(dmazzoni): http://crbug.com/404763 Get rid of the code that
+ // tracks the search key and just use meta everywhere.
+ if (cvox.ChromeVox.isChromeOS) {
David Tseng 2014/08/19 18:24:04 Is this needed (metaKeyName is only search on cros
dmazzoni 2014/08/19 19:59:26 You're right, it's redundant.
+ this.keys.metaKey[index] = false;
+ }
} else if (metaKeyName == 'Cmd' || metaKeyName == 'Win') {
this.keys.metaKey[index] = false;
}

Powered by Google App Engine
This is Rietveld 408576698