Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 479323002: Fix broken ChromeVox keyboard shortcuts. (Closed)

Created:
6 years, 4 months ago by dmazzoni
Modified:
6 years, 4 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix broken ChromeVox keyboard shortcuts. BUG=404770 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290758

Patch Set 1 #

Patch Set 2 : Proper fix #

Total comments: 4

Patch Set 3 : Simpler fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/key_sequence.js View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dmazzoni
Test is in follow-up changelist.
6 years, 4 months ago (2014-08-19 07:27:24 UTC) #1
David Tseng
https://codereview.chromium.org/479323002/diff/20001/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js File chrome/browser/resources/chromeos/chromevox/common/key_sequence.js (right): https://codereview.chromium.org/479323002/diff/20001/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js#newcode252 chrome/browser/resources/chromeos/chromevox/common/key_sequence.js:252: if (cvox.ChromeVox.isChromeOS) { Is this needed (metaKeyName is only ...
6 years, 4 months ago (2014-08-19 18:24:04 UTC) #2
dmazzoni
https://codereview.chromium.org/479323002/diff/20001/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js File chrome/browser/resources/chromeos/chromevox/common/key_sequence.js (right): https://codereview.chromium.org/479323002/diff/20001/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js#newcode252 chrome/browser/resources/chromeos/chromevox/common/key_sequence.js:252: if (cvox.ChromeVox.isChromeOS) { On 2014/08/19 18:24:04, David Tseng wrote: ...
6 years, 4 months ago (2014-08-19 19:59:26 UTC) #3
David Tseng
lgtm
6 years, 4 months ago (2014-08-19 20:36:17 UTC) #4
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 4 months ago (2014-08-19 21:23:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/479323002/40001
6 years, 4 months ago (2014-08-19 21:24:01 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 04:11:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 290758

Powered by Google App Engine
This is Rietveld 408576698