Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 479243002: Simplify DOMTokenList::validateToken() code (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
rwlbuis
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Simplify DOMTokenList::validateToken() code Simplify DOMTokenList::validateToken() code by calling WTFString::find() instead of manually iterating through the String to find HTML spaces. R=rob.buis@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M Source/core/dom/DOMTokenList.cpp View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rwlbuis
lgtm
6 years, 4 months ago (2014-08-18 17:30:13 UTC) #1
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-18 19:25:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/479243002/1
6 years, 4 months ago (2014-08-18 19:26:04 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 19:29:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (1) as 180486

Powered by Google App Engine
This is Rietveld 408576698