editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/type/Type.java - Issue 47923014: Issue 14364. Strengthen isDirectSupertypeOf() to check type parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/type/Type.java

Issue 47923014: Issue 14364. Strengthen isDirectSupertypeOf() to check type parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/InterfaceTypeImpl.java ('K') | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java ('k') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/type/Type.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/type/Type.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/type/Type.java

index cf03aeee192e8ec29756ca1c350064254718f039..d63efa0f5d7cc56bb277275c7b41e113d096c161 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/type/Type.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/type/Type.java

@@ -98,6 +98,15 @@ public interface Type {

public boolean isMoreSpecificThan(Type type);

/**

+ * Return {@code true} if this type is more specific than the given type.

+ *

+ * @param type the type being compared with this type

+ * @param withDynamic is {@code true} is "dynamic" should be considered as a subtype of any type

Brian Wilkerson 2013/10/30 14:00:02 nit: "is {@code true} is" --> "{@code true} if"

scheglov 2013/10/30 15:58:50 Done.

+ * @return {@code true} if this type is more specific than the given type

+ */

+ public boolean isMoreSpecificThan(Type type, boolean withDynamic);

+ /**

* Return {@code true} if this type represents the type 'Object'.

* @return {@code true} if this type represents the type 'Object'