LayoutTests/fast/table/table-rowspan-cell-with-empty-cell.html - Issue 47923009: Table rows are incorrectly collapsed in case of hidden cells and rowspans.

Unified Diff: LayoutTests/fast/table/table-rowspan-cell-with-empty-cell.html

Issue 47923009: Table rows are incorrectly collapsed in case of hidden cells and rowspans. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/platform/linux/fast/table/giantRowspan2-expected.png » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/table/table-rowspan-cell-with-empty-cell.html

diff --git a/LayoutTests/fast/table/table-rowspan-cell-with-empty-cell.html b/LayoutTests/fast/table/table-rowspan-cell-with-empty-cell.html

new file mode 100644

index 0000000000000000000000000000000000000000..ad99ad033e7775e6577cd5550124898e2a39a87a

--- /dev/null

+++ b/LayoutTests/fast/table/table-rowspan-cell-with-empty-cell.html

@@ -0,0 +1,35 @@

+<!DOCTYPE html>

+<html>

+<head>

+ <style>

+ table {border-collapse: collapse;}

+ .dn {display: none;}

+ .red {background: red;}

Julien - ping for review 2013/10/30 18:12:44 Red should be reserved for failures.

suchit.agrawal 2013/10/31 13:43:02 Changed to blue.

+ .green {background: green;}

+ </style>

+</head>

+<body>

+<h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=258420">258420</a>. Table rows are incorrectly collapsed in case of hidden cells and rowspans.</h3>

+<h4>When all rows in row spanning cell are having only spanning cells with empty cell/cells then None of the rows in row spanning cell was not getting any height.</h4>

Julien - ping for review 2013/10/30 18:12:44 None -> none (this is not a Python program :)) I

suchit.agrawal 2013/10/31 13:43:02 Done.

+<h4>A2 row should not collapse with other row in the table.</h4>

Julien - ping for review 2013/10/30 18:12:44 Can't we make that a check-layout.js test? It seem

suchit.agrawal 2013/10/31 13:43:02 Done.

+ <table>

+ <tbody>

+ <tr class="red">

+ <td rowspan="3">A</td>

+ <td>A1</td>

+ <td>A1.1</td>

+ </tr>

+ <tr>

+ <td rowspan="2">A2</td>

+ <td class="dn">A2.1</td>

+ </tr>

+ <tr>

+ <td class="dn">A2.2</td>

+ </tr>

+ <tr class="green">

+ <td colspan="3">long last row</td>

+ </tr>

+ </tbody>

+ </table>

+ </body>

+</html>