Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: LayoutTests/platform/win/fast/table/giantRowspan2-expected.txt

Issue 47923009: Table rows are incorrectly collapsed in case of hidden cells and rowspans. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addressed Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/platform/win/fast/table/giantRowspan2-expected.txt
diff --git a/LayoutTests/platform/win/fast/table/giantRowspan2-expected.txt b/LayoutTests/platform/win/fast/table/giantRowspan2-expected.txt
index 576fe0b83f366f5b2383bc104bec5c3c8fd145bd..5f40e75b43aa3024f080b9ba0c1ea063448f8489 100644
--- a/LayoutTests/platform/win/fast/table/giantRowspan2-expected.txt
+++ b/LayoutTests/platform/win/fast/table/giantRowspan2-expected.txt
@@ -3,15 +3,15 @@ layer at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
- RenderTable {TABLE} at (0,0) size 784x4
- RenderTableSection {TBODY} at (0,0) size 784x4
+ RenderTable {TABLE} at (0,0) size 784x84
+ RenderTableSection {TBODY} at (0,0) size 784x84
RenderTableRow {TR} at (0,2) size 784x0
- RenderTableCell {TD} at (2,-58) size 780x121 [r=0 c=0 rs=8190 cs=1]
- RenderText {#text} at (1,1) size 770x118
+ RenderTableCell {TD} at (2,1) size 780x82 [r=0 c=0 rs=8190 cs=1]
+ RenderText {#text} at (1,1) size 770x79
text run at (1,1) width 644: "This test succeeds if it does not crash. We implemented a heuristic a while back to prevent giant rowspans. "
text run at (645,1) width 126: "The heuristic did not,"
- text run at (1,60) width 611: "however, fix this case. This rowpsan was small enough so that we thought it was okay to allocate, but "
- text run at (612,60) width 131: "large enough so that it"
- text run at (1,80) width 599: "actually wasn't okay, and we crashed. Firefox seems to hold 8k as the maximum size for rowspans. "
- text run at (600,80) width 140: "So this change matches"
- text run at (1,100) width 341: "Firefox and clamps all rowspans to 8k right in the DOM."
+ text run at (1,21) width 611: "however, fix this case. This rowpsan was small enough so that we thought it was okay to allocate, but "
+ text run at (612,21) width 131: "large enough so that it"
+ text run at (1,41) width 599: "actually wasn't okay, and we crashed. Firefox seems to hold 8k as the maximum size for rowspans. "
+ text run at (600,41) width 140: "So this change matches"
+ text run at (1,61) width 341: "Firefox and clamps all rowspans to 8k right in the DOM."

Powered by Google App Engine
This is Rietveld 408576698