Source/core/rendering/RenderTableSection.h - Issue 47923009: Table rows are incorrectly collapsed in case of hidden cells and rowspans.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTableSection.h

Issue 47923009: Table rows are incorrectly collapsed in case of hidden cells and rowspans. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addressed Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/win/tables/mozilla/bugs/bug220536-expected.txt ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderTableSection.h

diff --git a/Source/core/rendering/RenderTableSection.h b/Source/core/rendering/RenderTableSection.h

index 37f49e268cf7f85a9974682b3a08cc79984d2e06..f8d476f6a3b92e70015b00226857fd2c5597c488 100644

--- a/Source/core/rendering/RenderTableSection.h

+++ b/Source/core/rendering/RenderTableSection.h

@@ -129,14 +129,14 @@ public:

SpanningRowsHeight()

: totalRowsHeight(0)

, spanningCellHeightIgnoringBorderSpacing(0)

- , rowWithOnlySpanningCells(false)

+ , isAnyRowWithOnlySpanningCells(false)

{

}

Vector<int> rowHeight;

int totalRowsHeight;

int spanningCellHeightIgnoringBorderSpacing;

- bool rowWithOnlySpanningCells;

+ bool isAnyRowWithOnlySpanningCells;

};

const BorderValue& borderAdjoiningTableStart() const