LayoutTests/fast/table/table-rowspan-cell-with-empty-cell.html - Issue 47923009: Table rows are incorrectly collapsed in case of hidden cells and rowspans.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/table-rowspan-cell-with-empty-cell.html

Issue 47923009: Table rows are incorrectly collapsed in case of hidden cells and rowspans. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <style>

	5 table {border-collapse: collapse;}

	6 .dn {display: none;}

	7 .red {background: red;}
	Julien - ping for review 2013/10/30 18:12:44 Red should be reserved for failures. Red should be reserved for failures. suchit.agrawal 2013/10/31 13:43:02 Changed to blue. Show quoted text On 2013/10/30 18:12:44, Julien Chaffraix - PST wrote: > Red should be reserved for failures. Changed to blue.
	8 .green {background: green;}

	9 </style>

	10 </head>

	11 <body>

	12 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/d etail?id=258420">258420</a>. Table rows are incorrectly collapsed in case of hid den cells and rowspans.</h3>

	13 <h4>When all rows in row spanning cell are having only spanning cells with empty cell/cells then None of the rows in row spanning cell was not getting any heigh t.</h4>
	Julien - ping for review 2013/10/30 18:12:44 None -> none (this is not a Python program :)) I None -> none (this is not a Python program :)) I think we could make the sentence more palatable: A spanning cell whose rows have only empty cell(s) shouldn't have a non-zero height. suchit.agrawal 2013/10/31 13:43:02 Done. Show quoted text On 2013/10/30 18:12:44, Julien Chaffraix - PST wrote: > None -> none (this is not a Python program :)) > > I think we could make the sentence more palatable: A spanning cell whose rows > have only empty cell(s) shouldn't have a non-zero height. Done.
	14 <h4>A2 row should not collapse with other row in the table.</h4>
	Julien - ping for review 2013/10/30 18:12:44 Can't we make that a check-layout.js test? It seem Can't we make that a check-layout.js test? It seems very easy to check that something is not 0 or has the right size. suchit.agrawal 2013/10/31 13:43:02 Done. Show quoted text On 2013/10/30 18:12:44, Julien Chaffraix - PST wrote: > Can't we make that a check-layout.js test? It seems very easy to check that > something is not 0 or has the right size. Done.
	15 <table>

	16 <tbody>

	17 <tr class="red">

	18 <td rowspan="3">A</td>

	19 <td>A1</td>

	20 <td>A1.1</td>

	21 </tr>

	22 <tr>

	23 <td rowspan="2">A2</td>

	24 <td class="dn">A2.1</td>

	25 </tr>

	26 <tr>

	27 <td class="dn">A2.2</td>

	28 </tr>

	29 <tr class="green">

	30 <td colspan="3">long last row</td>

	31 </tr>

	32 </tbody>

	33 </table>

	34 </body>

	35 </html>

OLD	NEW