LayoutTests/fast/table/table-rowspan-cell-with-empty-cell.html - Issue 47923009: Table rows are incorrectly collapsed in case of hidden cells and rowspans.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/table-rowspan-cell-with-empty-cell.html

Issue 47923009: Table rows are incorrectly collapsed in case of hidden cells and rowspans. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments Addressed Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-cell-with-empty-cell-expected.txt » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/check-layout.js"></script>

	5 <style>

	6 td { font: 15px/1 Ahem }

	7 table {border-collapse: collapse;}

	8 .dn {display: none;}

	9 .red {background: blue;}
	Julien - ping for review 2013/11/13 07:13:17 .red -> background blue There is probably a misma .red -> background blue There is probably a mismatch in the class name here. a.suchit 2013/11/19 11:59:56 Done. Show quoted text On 2013/11/13 07:13:17, Julien Chaffraix - AEDT wrote: > .red -> background blue > > There is probably a mismatch in the class name here. Done.
	10 .green {background: green;}

	11 </style>

	12 </head>

	13 <body onload="checkLayout('#a')">

	14 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/d etail?id=258420">258420</a>. Table rows are incorrectly collapsed in case of hid den cells and rowspans.</h3>

	15 <h4>A spanning cell whose rows have only empty cell(s) shouldn't have a non-zero height.</h4>

	16 <table>

	17 <tbody>

	18 <tr class="red">

	19 <td rowspan="3">A</td>

	20 <td>A1</td>

	21 <td>A1.1</td>

	22 </tr>

	23 <tr>

	24 <td rowspan="2" id="a" data-expected-width = "56">A2</td>

	25 <td class="dn">A2.1</td>

	26 </tr>

	27 <tr>

	28 <td class="dn">A2.2</td>

	29 </tr>

	30 <tr class="green">

	31 <td colspan="3">long last row</td>

	32 </tr>

	33 </tbody>

	34 </table>

	35 </body>

	36 </html>

OLD	NEW