Source/core/xml/parser/XMLDocumentParser.cpp - Issue 47923008: Block execution of failed 'crossorigin' <script>s.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/parser/XMLDocumentParser.cpp

Issue 47923008: Block execution of failed 'crossorigin' <script>s. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Minimize code changes + remove redundant leftovers. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/xml/parser/XMLDocumentParser.cpp

diff --git a/Source/core/xml/parser/XMLDocumentParser.cpp b/Source/core/xml/parser/XMLDocumentParser.cpp

index 5d6a1eb3d4c5e97c2758b9baf21b03cabc80af36..5be6fc02007d0d66b2c181d7bccaa1965bc252db 100644

--- a/Source/core/xml/parser/XMLDocumentParser.cpp

+++ b/Source/core/xml/parser/XMLDocumentParser.cpp

@@ -474,8 +474,8 @@ void XMLDocumentParser::notifyFinished(Resource* unusedResource)

if (errorOccurred)

scriptLoader->dispatchErrorEvent();

else if (!wasCanceled) {

- scriptLoader->executeScript(sourceCode);

- scriptLoader->dispatchLoadEvent();

+ if (scriptLoader->executePotentiallyCrossOriginScript(sourceCode))

+ scriptLoader->dispatchLoadEvent();

}

m_scriptElement = 0;