Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: LayoutTests/http/tests/security/script-onerror-crossorigin-no-cors.html

Issue 47923008: Block execution of failed 'crossorigin' <script>s. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/security/script-onerror-crossorigin-no-cors.html
diff --git a/LayoutTests/http/tests/security/script-onerror-crossorigin-no-cors.html b/LayoutTests/http/tests/security/script-onerror-crossorigin-no-cors.html
index 3edbe3007e573230afe8fb7f60e30b943a8bdfd7..9c25b55a633cddc18099986d96f9f39f65576ead 100644
--- a/LayoutTests/http/tests/security/script-onerror-crossorigin-no-cors.html
+++ b/LayoutTests/http/tests/security/script-onerror-crossorigin-no-cors.html
@@ -5,23 +5,24 @@
<script src="../../js-test-resources/js-test-pre.js"></script>
<script>
window.jsTestIsAsync = true;
- description("The test passes if 'window.onerror' gets sanitized information about an exception thrown in a script loaded with a 'crossorigin' attribute, and delivered without valid CORS headers.");
+ description("The test passes if 'window.onerror' is not invoked on a script loaded with a 'crossorigin' attribute, but delivered without valid CORS headers.");
+
+ var still_running = true;
+ function shutdown() {
+ if (still_running) {
+ finishJSTest();
+ still_running = false;
+ }
+ }
window.onerror = function(msg, url, line, column, error) {
- window.msg = msg;
- window.url = url;
- window.line = line;
- window.column = column;
- window.errorObject = error;
- shouldBeEqualToString("msg", "Script error.");
- shouldBeEqualToString("url", "");
- shouldBe("line", "0");
- shouldBe("column", "0");
- shouldBeNull("window.errorObject");
- finishJSTest();
+ window.fail = "FAIL";
+ shouldBeUndefined("window.fail");
+ shutdown();
}
</script>
<script crossorigin="anonymous" src="http://localhost:8000/security/resources/cors-script.php?fail=true&cors=false"></script>
<script src="../../js-test-resources/js-test-post.js"></script>
+ <script>shutdown();</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698