LayoutTests/http/tests/security/script-onerror-crossorigin-no-cors.html - Issue 47923008: Block execution of failed 'crossorigin' <script>s.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/security/script-onerror-crossorigin-no-cors.html

Issue 47923008: Block execution of failed 'crossorigin' <script>s. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Minimize code changes + remove redundant leftovers. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/security/script-crossorigin-loads-cross-origin-expected.txt ('k') | LayoutTests/http/tests/security/script-onerror-crossorigin-no-cors-expected.txt » ('j') | Source/core/dom/ScriptLoader.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <head>	2 <head>

3 </head>	3 </head>

4 <body>	4 <body>

5 <script src="../../js-test-resources/js-test-pre.js"></script>	5 <script src="../../js-test-resources/js-test-pre.js"></script>

6 <script>	6 <script>

7 window.jsTestIsAsync = true;	7 window.jsTestIsAsync = true;

8 description("The test passes if 'window.onerror' gets sanitized informat ion about an exception thrown in a script loaded with a 'crossorigin' attribute, and delivered without valid CORS headers.");	8 description("The test passes if 'window.onerror' is not invoked on a scr ipt loaded with a 'crossorigin' attribute, but delivered without valid CORS head ers.");

	9

	10 var still_running = true;

	11 function shutdown() {

	12 if (still_running) {

	13 finishJSTest();

	14 still_running = false;

	15 }

	16 }

9	17

10 window.onerror = function(msg, url, line, column, error) {	18 window.onerror = function(msg, url, line, column, error) {

11 window.msg = msg;	19 window.fail = "FAIL";

12 window.url = url;	20 shouldBeUndefined("window.fail");

13 window.line = line;	21 shutdown();

14 window.column = column;

15 window.errorObject = error;

16 shouldBeEqualToString("msg", "Script error.");

17 shouldBeEqualToString("url", "");

18 shouldBe("line", "0");

19 shouldBe("column", "0");

20 shouldBeNull("window.errorObject");

21 finishJSTest();

22 }	22 }

23 </script>	23 </script>

24 <script crossorigin="anonymous" src="http://localhost:8000/security/resource s/cors-script.php?fail=true&cors=false"></script>	24 <script crossorigin="anonymous" src="http://localhost:8000/security/resource s/cors-script.php?fail=true&cors=false"></script>

25 <script src="../../js-test-resources/js-test-post.js"></script>	25 <script src="../../js-test-resources/js-test-post.js"></script>

	26 <script>shutdown();</script>

26 </body>	27 </body>

27 </html>	28 </html>

OLD	NEW