Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 479163002: [turbofan] Add new ControlEffect and Finish operators. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add new ControlEffect and Finish operators. Fix the ChangeLowering to properly use ControlEffect nodes to turn the control output of IfTrue nodes into an effect input for the Load nodes, and to properly use Finish nodes to ensure that allocation and store were both performed prior to actually using the allocated heap number. TEST=compiler-unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -66 lines) Patch
M src/compiler/change-lowering.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/common-operator.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/operator-properties-inl.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/compiler-unittests/change-lowering-unittest.cc View 3 chunks +47 lines, -40 lines 0 comments Download
M test/compiler-unittests/common-operator-unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M test/compiler-unittests/graph-unittest.h View 1 chunk +13 lines, -0 lines 0 comments Download
M test/compiler-unittests/graph-unittest.cc View 8 chunks +136 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 4 months ago (2014-08-18 11:07:38 UTC) #1
Jarin
lgtm
6 years, 4 months ago (2014-08-18 11:35:24 UTC) #2
Benedikt Meurer
6 years, 4 months ago (2014-08-18 11:36:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23149 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698