Add ManagePasswordsBubbleConfirmationViewController and unit tests.

Committed: https://crrev.com/c9d27bad6c594837984a68257f0008f7a2e008b0
Cr-Commit-Position: refs/heads/master@{#291675}

[Scott Hess - ex-Googler, 2014-08-22 21:49:39]

LGTM, unless your answer to the comment is "No, they're bytes".

https://codereview.chromium.org/479123003/diff/60001/chrome/browser/ui/cocoa/...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm
(right):

https://codereview.chromium.org/479123003/diff/60001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm:80:
addLinkRange:model_->save_confirmation_link_range().ToNSRange()
Just to double-check - these are consistently in characters, not bytes, right?

[dconnelly, 2014-08-25 09:36:53]

https://codereview.chromium.org/479123003/diff/60001/chrome/browser/ui/cocoa/...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm
(right):

https://codereview.chromium.org/479123003/diff/60001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm:80:
addLinkRange:model_->save_confirmation_link_range().ToNSRange()
On 2014/08/22 21:49:39, Scott Hess wrote:
> Just to double-check - these are consistently in characters, not bytes, right?

Correct. The link range comes from using base::SplitString on a base::string16
and measuring the lengths of the resulting strings.

[dconnelly, 2014-08-25 09:37:18]

-mkwst +vabr for chrome/browser/ui/passwords

[vabr (Chromium), 2014-08-25 09:54:44]

chrome/browser/ui/passwords LGTM

[dconnelly, 2014-08-25 09:55:53]

The CQ bit was checked by dconnelly@chromium.org

[commit-bot: I haz the power, 2014-08-25 09:57:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dconnelly@chromium.org/479123003/60001

[commit-bot: I haz the power, 2014-08-25 11:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-25 11:26:23]

Failed to apply patch for chrome/chrome_browser_ui.gypi:
While running git apply --index -p1;
  error: patch failed: chrome/chrome_browser_ui.gypi:629
  error: chrome/chrome_browser_ui.gypi: patch does not apply

Patch:       chrome/chrome_browser_ui.gypi
Index: chrome/chrome_browser_ui.gypi
diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi
index
010094e5428f830a3bd66165482b374e4982e8fb..1568a1ff40fc6f6b49f4c6054855c9b17cf227de
100644
--- a/chrome/chrome_browser_ui.gypi
+++ b/chrome/chrome_browser_ui.gypi
@@ -629,6 +629,8 @@
       'browser/ui/cocoa/panels/panel_window_controller_cocoa.mm',
       'browser/ui/cocoa/passwords/manage_password_item_view_controller.h',
       'browser/ui/cocoa/passwords/manage_password_item_view_controller.mm',
+     
'browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.h',
+     
'browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm',
      
'browser/ui/cocoa/passwords/manage_passwords_bubble_content_view_controller.h',
      
'browser/ui/cocoa/passwords/manage_passwords_bubble_content_view_controller.mm',
       'browser/ui/cocoa/passwords/manage_passwords_bubble_controller.h',

[dconnelly, 2014-08-25 11:48:14]

The CQ bit was checked by dconnelly@chromium.org

[commit-bot: I haz the power, 2014-08-25 11:48:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dconnelly@chromium.org/479123003/80001

[commit-bot: I haz the power, 2014-08-25 12:42:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/50967)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-25 13:13:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-25 13:13:33]

Failed to commit the patch.

[dconnelly, 2014-08-25 13:15:16]

The CQ bit was checked by dconnelly@chromium.org

[commit-bot: I haz the power, 2014-08-25 13:16:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dconnelly@chromium.org/479123003/80001

[commit-bot: I haz the power, 2014-08-25 13:16:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-25 13:16:51]

Failed to apply patch for
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.h:
While running git apply --index -p1;
  error:
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.h:
already exists in index

Patch:   N  
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.h
Index:
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.h
diff --git
a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.h
b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.h
new file mode 100644
index
0000000000000000000000000000000000000000..8e7a7aa4e511971c435949bef4bb4a2d7eeb6bc7
--- /dev/null
+++
b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.h
@@ -0,0 +1,34 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef
CHROME_BROWSER_UI_COCOA_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_CONFIRMATION_VIEW_CONTROLLER_H_
+#define
CHROME_BROWSER_UI_COCOA_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_CONFIRMATION_VIEW_CONTROLLER_H_
+
+#import <Cocoa/Cocoa.h>
+
+#include "base/mac/scoped_nsobject.h"
+#import
"chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_content_view_controller.h"
+
+@class HyperlinkTextView;
+class ManagePasswordsBubbleModel;
+
+// Manages the view that confirms that the generated password was saved.
+@interface ManagePasswordsBubbleConfirmationViewController
+    : ManagePasswordsBubbleContentViewController<NSTextViewDelegate> {
+ @private
+  ManagePasswordsBubbleModel* model_;  // weak
+  id<ManagePasswordsBubbleContentViewDelegate> delegate_;  // weak
+  base::scoped_nsobject<HyperlinkTextView> confirmationText_;
+  base::scoped_nsobject<NSButton> okButton_;
+}
+- (id)initWithModel:(ManagePasswordsBubbleModel*)model
+           delegate:(id<ManagePasswordsBubbleContentViewDelegate>)delegate;
+@end
+
+@interface ManagePasswordsBubbleConfirmationViewController (Testing)
+@property(readonly) HyperlinkTextView* confirmationText;
+@property(readonly) NSButton* okButton;
+@end
+
+#endif  //
CHROME_BROWSER_UI_COCOA_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_CONFIRMATION_VIEW_CONTROLLER_H_

[commit-bot: I haz the power, 2014-09-10 02:34:16]

Patchset 3 (id:??) landed as
https://crrev.com/c9d27bad6c594837984a68257f0008f7a2e008b0
Cr-Commit-Position: refs/heads/master@{#291675}