Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 479123002: ServiceWorker: Remove macros that were used to introduce SWRegistration (Closed)

Created:
6 years, 4 months ago by nhiroki
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Remove macros that were used to introduce SWRegistration These macros are no longer necessary after https://codereview.chromium.org/466723002/ BUG=396400 TEST=content_unittests --gtest_filter=ServiceWorker* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290224

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -34 lines) Patch
M content/child/service_worker/service_worker_dispatcher.cc View 1 4 chunks +11 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nhiroki
Ptal, thanks!
6 years, 4 months ago (2014-08-18 06:26:29 UTC) #1
falken
lgtm, yay! https://codereview.chromium.org/479123002/diff/1/content/child/service_worker/service_worker_dispatcher.cc File content/child/service_worker/service_worker_dispatcher.cc (right): https://codereview.chromium.org/479123002/diff/1/content/child/service_worker/service_worker_dispatcher.cc#newcode253 content/child/service_worker/service_worker_dispatcher.cc:253: // We should adopt and destroy an ...
6 years, 4 months ago (2014-08-18 06:41:39 UTC) #2
nhiroki
https://codereview.chromium.org/479123002/diff/1/content/child/service_worker/service_worker_dispatcher.cc File content/child/service_worker/service_worker_dispatcher.cc (right): https://codereview.chromium.org/479123002/diff/1/content/child/service_worker/service_worker_dispatcher.cc#newcode253 content/child/service_worker/service_worker_dispatcher.cc:253: // We should adopt and destroy an unused handle ...
6 years, 4 months ago (2014-08-18 06:45:34 UTC) #3
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 4 months ago (2014-08-18 06:45:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/479123002/20001
6 years, 4 months ago (2014-08-18 06:46:50 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-18 08:05:06 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 08:14:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290224

Powered by Google App Engine
This is Rietveld 408576698