Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 479113004: Remove conservative sweeping. (Closed)

Created:
6 years, 4 months ago by Hannes Payer (out of office)
Modified:
6 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove conservative sweeping. BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23283

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -371 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M src/heap/heap.h View 1 2 3 1 chunk +5 lines, -8 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/heap/mark-compact.h View 1 2 3 4 3 chunks +3 lines, -15 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 18 chunks +45 lines, -270 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/spaces.h View 1 4 chunks +8 lines, -24 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 4 8 chunks +5 lines, -17 lines 0 comments Download
M src/heap/store-buffer.cc View 1 2 chunks +10 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jarin
Very nice. I have a couple of questions. https://codereview.chromium.org/479113004/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/479113004/diff/20001/src/heap/mark-compact.cc#newcode3303 src/heap/mark-compact.cc:3303: static ...
6 years, 4 months ago (2014-08-21 08:29:12 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/479113004/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/479113004/diff/20001/src/heap/mark-compact.cc#newcode3303 src/heap/mark-compact.cc:3303: static int SweepPrecisely(PagedSpace* space, FreeList* free_list, Page* p, On ...
6 years, 4 months ago (2014-08-21 09:03:17 UTC) #2
Jarin
On 2014/08/21 09:03:17, Hannes Payer wrote: > https://codereview.chromium.org/479113004/diff/20001/src/heap/mark-compact.cc > File src/heap/mark-compact.cc (right): > > https://codereview.chromium.org/479113004/diff/20001/src/heap/mark-compact.cc#newcode3303 ...
6 years, 4 months ago (2014-08-21 10:59:25 UTC) #3
Hannes Payer (out of office)
Yes, makes perfect sense. Thanks!
6 years, 4 months ago (2014-08-21 14:48:47 UTC) #4
Hannes Payer (out of office)
6 years, 4 months ago (2014-08-21 14:50:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as 23283 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698