Issue 479113003: Add tests for removing the parent/child of the fullscreen element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 479113003: Add tests for removing the parent/child of the fullscreen element (Closed)

Created:
6 years, 4 months ago by philipj_slow

Modified:
6 years, 4 months ago

Reviewers:
falken

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Add tests for removing the parent/child of the fullscreen element The parent test would fail if Fullscreen::elementRemoved() were only called for the top-most removed element. The child test would require a more serious misinterpretation of "in fullscreen element stack". BUG=383813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180700

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -7 lines)			Patch
M	LayoutTests/fullscreen/api/element-request-fullscreen-top.html	View	1 chunk	+1 line, -1 line	0 comments	Download
A	LayoutTests/fullscreen/model/remove-child.html	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A +	LayoutTests/fullscreen/model/remove-parent.html	View	1 chunk	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/479113003/1

6 years, 4 months ago (2014-08-21 06:04:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180700

Expand Messages | Collapse Messages