Issue 479083006: Revert of [Android] Consolidate vsync request logic in RWHVAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 479083006: Revert of [Android] Consolidate vsync request logic in RWHVAndroid (Closed)

Created:
6 years, 4 months ago by cjhopman

Modified:
6 years, 3 months ago

Reviewers:
jdduke (slow), no sievers

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, boliu

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of [Android] Consolidate vsync request logic in RWHVAndroid (patchset #5 of https://codereview.chromium.org/492923002/) Reason for revert: BUG=406651 In tests, seems we are calling StartObservingRootWindow multiple times. Original issue's description: > [Android] Consolidate vsync request logic in RWHVAndroid > > The current vsync subscription scheme in RWHVAndroid is rather ad-hoc. Formalize > the request logic by creating explicit request types, avoiding redundant vsync > requests (and the associated JNI call) while also enforcing the validity of > such requests (for WebView). > > BUG=394604 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291296 TBR=sievers@chromium.org,jdduke@chromium.org NOTREECHECKS=true NOTRY=true BUG=394604

Patch Set 1 #

Created: 6 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -94 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_android.h	View		3 chunks	+4 lines, -11 lines	0 comments	Download
	M	content/browser/renderer_host/render_widget_host_view_android.cc	View		11 chunks	+54 lines, -83 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cjhopman

Created Revert of [Android] Consolidate vsync request logic in RWHVAndroid

6 years, 4 months ago (2014-08-23 00:19:18 UTC) #1

jdduke (slow)

6 years, 4 months ago (2014-08-23 01:17:51 UTC) #3

On 2014/08/23 01:17:09, jdduke wrote:
> The CQ bit was unchecked by mailto:jdduke@chromium.org

Since we're migrating, I went ahead with a quick fix:
https://codereview.chromium.org/493053004/.

Expand Messages | Collapse Messages