Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 479033002: DevTools: improve javascript formatter to support "return" properties. (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: improve javascript formatter to support "return" properties. The uglifier tokenizer, which is used under the hood in javascript formatter, is not clever enough to figure out that the "return" word in "a.return" is not a "return" statement, but identifier. This patch works around this issue via verifying the token value after regex to be a valid identifier. BUG=218470 R=vsevik, apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180467

Patch Set 1 #

Patch Set 2 : address @vsevik comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M LayoutTests/inspector/sources/debugger/script-formatter.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/script-formatter-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/script_formatter_worker/JavaScriptFormatter.js View 1 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
lushnikov
6 years, 4 months ago (2014-08-17 13:28:55 UTC) #1
lushnikov
6 years, 4 months ago (2014-08-18 09:33:44 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-18 09:33:53 UTC) #3
vsevik
lgtm
6 years, 4 months ago (2014-08-18 09:33:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/479033002/20001
6 years, 4 months ago (2014-08-18 09:34:44 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-18 10:36:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 11:02:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/21062)
6 years, 4 months ago (2014-08-18 11:02:27 UTC) #8
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-18 14:34:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/479033002/20001
6 years, 4 months ago (2014-08-18 14:35:37 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 15:33:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180467

Powered by Google App Engine
This is Rietveld 408576698