Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3668)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/dom_ui/new_tab_ui.cc

Issue 479: DidNavigate refactor of doom (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/back_forward_menu_model_unittest.cc ('k') | chrome/browser/native_ui_contents.cc » ('j') | chrome/browser/navigation_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/new_tab_ui.cc
===================================================================
--- chrome/browser/dom_ui/new_tab_ui.cc (revision 1840)
+++ chrome/browser/dom_ui/new_tab_ui.cc (working copy)
@@ -797,15 +797,9 @@
}
}
-bool NewTabUIContents::Navigate(const NavigationEntry& entry, bool reload) {
- const bool result = WebContents::Navigate(entry, reload);
-
- // Force the title to say 'New tab', even when loading. The supplied entry is
- // also the pending entry.
- NavigationEntry* pending_entry = controller()->GetPendingEntry();
- DCHECK(pending_entry && pending_entry == &entry);
- pending_entry->set_title(forced_title_);
-
+bool NewTabUIContents::NavigateToPendingEntry(bool reload) {
+ const bool result = WebContents::NavigateToPendingEntry(reload);
+ controller()->GetPendingEntry()->set_title(forced_title_);
return result;
}
« no previous file with comments | « chrome/browser/back_forward_menu_model_unittest.cc ('k') | chrome/browser/native_ui_contents.cc » ('j') | chrome/browser/navigation_controller.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698