Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: chrome/browser/tabs/tab_strip_model_unittest.cc

Issue 479: DidNavigate refactor of doom (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tabs/tab_strip_model_unittest.cc
===================================================================
--- chrome/browser/tabs/tab_strip_model_unittest.cc (revision 1840)
+++ chrome/browser/tabs/tab_strip_model_unittest.cc (working copy)
@@ -31,25 +31,8 @@
TabStripModelTestTabContents(const TabContentsType type)
: TabContents(type) {
}
-
- bool Navigate(const NavigationEntry& entry, bool reload) {
- NavigationEntry* pending_entry = new NavigationEntry(entry);
- if (pending_entry->page_id() == -1) {
- pending_entry->set_page_id(g_page_id_++);
- }
- NavigationController::LoadCommittedDetails details;
- DidNavigateToEntry(pending_entry, &details);
-
- return true;
- }
-
- private:
- // We need to use valid, incrementing page ids otherwise the TabContents
- // and NavController will not play nice when we try to go back and forward.
- static int g_page_id_;
};
-int TabStripModelTestTabContents::g_page_id_ = 0;
// This constructs our fake TabContents.
class TabStripModelTestTabContentsFactory : public TabContentsFactory {

Powered by Google App Engine
This is Rietveld 408576698