Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 478963002: DevTools: [CodeMirror] handle new-lines in error popovers (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [CodeMirror] handle new-lines in error popovers Add support to new-line character handling in error and warning console message texts which are shown in a popover in editor. BUG=404380 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M Source/devtools/front_end/cmdevtools.css View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/source_frame/SourceFrame.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
ptal
6 years, 4 months ago (2014-08-16 18:16:00 UTC) #1
vsevik
lgtm
6 years, 4 months ago (2014-08-16 22:04:00 UTC) #2
lushnikov
On 2014/08/16 22:04:00, vsevik wrote: > lgtm midnight lgtm :)
6 years, 4 months ago (2014-08-16 23:16:06 UTC) #3
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-16 23:16:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/478963002/1
6 years, 4 months ago (2014-08-16 23:16:55 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-17 00:18:05 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-17 00:44:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 180413

Powered by Google App Engine
This is Rietveld 408576698