Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 478943002: DevTools: fix protocol.json Page.colorPicked event (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: fix protocol.json Page.colorPicked event The event should report DOM.RGBA color instead of string. R=pfeldman@chromium.org, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/protocol.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
lushnikov
ptal
6 years, 4 months ago (2014-08-16 16:17:23 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-16 16:18:05 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-16 16:18:20 UTC) #3
lushnikov
The CQ bit was unchecked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-16 16:18:23 UTC) #4
lushnikov
6 years, 4 months ago (2014-08-16 16:18:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 180409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698