athena: Add some tests for the existing wm functionalities.

athena: Add some tests for the existing wm functionalities.

Adds tests for basic operations for split-view mode, overview mode,
title-drag to switch between windows (in both normal and split view mode).

BUG=403945
R=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290273

[oshima, 2014-08-18 14:48:43]

thanks, that's along the line with what I was thinking.
I first wanted to move test api into test (and had issue with DEPS), but this is
simpler and enough.

https://codereview.chromium.org/478903002/diff/120001/athena/wm/window_manage...
File athena/wm/window_manager_impl.h (right):

https://codereview.chromium.org/478903002/diff/120001/athena/wm/window_manage...
athena/wm/window_manager_impl.h:41: 
remove new line

https://codereview.chromium.org/478903002/diff/120001/athena/wm/window_manage...
File athena/wm/window_manager_unittest.cc (right):

https://codereview.chromium.org/478903002/diff/120001/athena/wm/window_manage...
athena/wm/window_manager_unittest.cc:67:
wm_api.container()->AddChild(second.get());
can you use aura::client::ParentWindowWithContext ?

https://codereview.chromium.org/478903002/diff/120001/athena/wm/window_manage...
athena/wm/window_manager_unittest.cc:209: EXPECT_EQ(second.get(),
*windows.rbegin());
windows[3]
       [2]
       [1]

maybe more readable, although I don't feel strongly about it.

[sadrul, 2014-08-18 15:46:46]

https://codereview.chromium.org/478903002/diff/120001/athena/wm/window_manage...
File athena/wm/window_manager_impl.h (right):

https://codereview.chromium.org/478903002/diff/120001/athena/wm/window_manage...
athena/wm/window_manager_impl.h:41: 
On 2014/08/18 14:48:43, oshima wrote:
> remove new line

Done.

https://codereview.chromium.org/478903002/diff/120001/athena/wm/window_manage...
File athena/wm/window_manager_unittest.cc (right):

https://codereview.chromium.org/478903002/diff/120001/athena/wm/window_manage...
athena/wm/window_manager_unittest.cc:67:
wm_api.container()->AddChild(second.get());
On 2014/08/18 14:48:43, oshima wrote:
> can you use aura::client::ParentWindowWithContext ?

Done.

https://codereview.chromium.org/478903002/diff/120001/athena/wm/window_manage...
athena/wm/window_manager_unittest.cc:209: EXPECT_EQ(second.get(),
*windows.rbegin());
On 2014/08/18 14:48:43, oshima wrote:
> windows[3]
>        [2]
>        [1]
> 
> maybe more readable, although I don't feel strongly about it.

Done.

[oshima, 2014-08-18 16:03:52]

https://codereview.chromium.org/478903002/diff/140001/athena/wm/window_manage...
File athena/wm/window_manager_unittest.cc (right):

https://codereview.chromium.org/478903002/diff/140001/athena/wm/window_manage...
athena/wm/window_manager_unittest.cc:68: first.get(), wm_api.container(),
gfx::Rect());
can you use ScreenManager::GetContext() ?

https://codereview.chromium.org/478903002/diff/140001/athena/wm/window_manage...
athena/wm/window_manager_unittest.cc:74:
EXPECT_EQ(wm_api.container()->bounds().size().ToString(),
this should be gfx::Screen::GetPrimaryDisplay()->work_area()

(peter has change to adjust the size)

[sadrul, 2014-08-18 16:18:18]

https://codereview.chromium.org/478903002/diff/140001/athena/wm/window_manage...
File athena/wm/window_manager_unittest.cc (right):

https://codereview.chromium.org/478903002/diff/140001/athena/wm/window_manage...
athena/wm/window_manager_unittest.cc:68: first.get(), wm_api.container(),
gfx::Rect());
On 2014/08/18 16:03:51, oshima wrote:
> can you use ScreenManager::GetContext() ?

Done.

https://codereview.chromium.org/478903002/diff/140001/athena/wm/window_manage...
athena/wm/window_manager_unittest.cc:74:
EXPECT_EQ(wm_api.container()->bounds().size().ToString(),
On 2014/08/18 16:03:51, oshima wrote:
> this should be gfx::Screen::GetPrimaryDisplay()->work_area()
> 
> (peter has change to adjust the size)

Done.

[oshima, 2014-08-18 17:03:06]

lgtm

https://codereview.chromium.org/478903002/diff/180001/athena/wm/window_manage...
File athena/wm/window_manager_unittest.cc (right):

https://codereview.chromium.org/478903002/diff/180001/athena/wm/window_manage...
athena/wm/window_manager_unittest.cc:43: aura::Window* container() { return
wm_->container_.get(); }
nit: remove this

[sadrul, 2014-08-18 17:06:02]

https://codereview.chromium.org/478903002/diff/180001/athena/wm/window_manage...
File athena/wm/window_manager_unittest.cc (right):

https://codereview.chromium.org/478903002/diff/180001/athena/wm/window_manage...
athena/wm/window_manager_unittest.cc:43: aura::Window* container() { return
wm_->container_.get(); }
On 2014/08/18 17:03:05, oshima wrote:
> nit: remove this

Done.

[sadrul, 2014-08-18 17:07:16]

Committed patchset #8 manually as 290273 (presubmit successful).