Issue 478853005: Add dependency on widevine headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 478853005: Add dependency on widevine headers. (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
jam

CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Add dependency on widevine headers. This is needed by some files in these targets. The GYP build has this dependency. TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291340

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	media/base/android/BUILD.gn	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

jamesr

I'm trying to do the same thing here https://codereview.chromium.org/498573002/ but keep bouncing out of the ...

6 years, 4 months ago (2014-08-22 05:40:33 UTC) #2

brettw

You also need to add it to the unit tests project. I don't know what ...

6 years, 4 months ago (2014-08-22 06:10:54 UTC) #3

brettw

6 years, 4 months ago (2014-08-22 06:14:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 291340 (tree was closed).