Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 478833002: Add some trivial window decorations & window closing back to the demo window manager (Closed)

Created:
6 years, 4 months ago by Ben Goodger (Google)
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add some trivial window decorations & window closing back to the demo window manager R=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290120

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -11 lines) Patch
M mojo/examples/wm_flow/app/app.cc View 1 2 4 chunks +33 lines, -8 lines 0 comments Download
M mojo/examples/wm_flow/wm/wm.cc View 1 2 3 chunks +34 lines, -3 lines 0 comments Download
M mojo/services/view_manager/node.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ben Goodger (Google)
6 years, 4 months ago (2014-08-15 23:06:58 UTC) #1
sky
LGTM https://codereview.chromium.org/478833002/diff/20001/mojo/examples/wm_flow/app/app.cc File mojo/examples/wm_flow/app/app.cc (right): https://codereview.chromium.org/478833002/diff/20001/mojo/examples/wm_flow/app/app.cc#newcode80 mojo/examples/wm_flow/app/app.cc:80: root->AddObserver(this); Remove this some where? https://codereview.chromium.org/478833002/diff/20001/mojo/examples/wm_flow/wm/wm.cc File mojo/examples/wm_flow/wm/wm.cc ...
6 years, 4 months ago (2014-08-15 23:09:36 UTC) #2
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 4 months ago (2014-08-15 23:14:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/478833002/40001
6 years, 4 months ago (2014-08-15 23:16:07 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 07:55:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 290120

Powered by Google App Engine
This is Rietveld 408576698