Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 478823003: Shape across HarfBuzz runs (Closed)

Created:
6 years, 4 months ago by eae
Modified:
6 years, 4 months ago
CC:
blink-reviews, Rik, danakj, krit, jamesr, jbroman, pdr., rwlbuis, Stephen Chennney
Project:
blink
Visibility:
Public.

Description

Shape across HarfBuzz runs Change HarfBuzzShaper to shape text across HarfBuzzRuns. This allows for better handling of zero width joiners and is the first step towards supporting shaping across elements. Must land after change 167703008 as without that change it will cache incorrect information due to the text string value no longer being sufficient as shaping now includes contextual information from adjacent runs. R=behdad@chromium.org,leviw@chromium.org BUG=345401 TEST=PerformanceTests/Layout/hindi-line-layout.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180470

Patch Set 1 #

Patch Set 2 : w/o cache changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp View 1 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eae
6 years, 4 months ago (2014-08-15 22:42:01 UTC) #1
behdad_google
lgtm
6 years, 4 months ago (2014-08-15 22:45:42 UTC) #2
leviw_travelin_and_unemployed
Make a comment in the description about waiting for the other patch to land and ...
6 years, 4 months ago (2014-08-15 23:01:47 UTC) #3
leviw_travelin_and_unemployed
(Also, I wish we had unit tests for this...)
6 years, 4 months ago (2014-08-15 23:02:04 UTC) #4
eae
On 2014/08/15 23:02:04, leviw wrote: > (Also, I wish we had unit tests for this...) ...
6 years, 4 months ago (2014-08-15 23:02:34 UTC) #5
eae
The CQ bit was checked by eae@chromium.org
6 years, 4 months ago (2014-08-18 15:22:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/478823003/20001
6 years, 4 months ago (2014-08-18 15:22:56 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 15:53:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180470

Powered by Google App Engine
This is Rietveld 408576698