Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 478823002: Don't repaint squashed, fixed position layers during scrolling (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, chrishtr, esprehn
Project:
blink
Visibility:
Public.

Description

Don't repaint squashed, fixed position layers during scrolling There's no need to repaint fixed position layers that are squashed. Necessarily they must be squashed onto other fixed position layers, which means they don't move during scrolling. R=vollick@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180410

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -13 lines) Patch
A LayoutTests/compositing/repaint/scroll-fixed-squahed-layer.html View 1 1 chunk +38 lines, -0 lines 0 comments Download
A + LayoutTests/compositing/repaint/scroll-fixed-squahed-layer-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-15 22:19:29 UTC) #1
abarth-chromium
6 years, 4 months ago (2014-08-15 22:19:52 UTC) #2
Ian Vollick
On 2014/08/15 22:19:52, abarth wrote: Looks like there's an exception making its way into the ...
6 years, 4 months ago (2014-08-15 23:53:55 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-16 15:56:57 UTC) #4
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-16 15:56:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/478823002/20001
6 years, 4 months ago (2014-08-16 15:57:27 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 16:57:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180410

Powered by Google App Engine
This is Rietveld 408576698