Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 478793002: Turns on filtering of tests everywhere (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Turns on filtering of tests everywhere filter_tests_builders becomes non_filter_tests_builders BUG=109173 TEST=none R=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=290265

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M scripts/slave/recipes/chromium_trybot.py View 5 chunks +23 lines, -8 lines 3 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
6 years, 4 months ago (2014-08-15 21:01:18 UTC) #1
iannucci
lgtm https://codereview.chromium.org/478793002/diff/1/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/478793002/diff/1/scripts/slave/recipes/chromium_trybot.py#newcode427 scripts/slave/recipes/chromium_trybot.py:427: for regex in regexs: Technically, you could create ...
6 years, 4 months ago (2014-08-15 22:36:23 UTC) #2
sky
https://codereview.chromium.org/478793002/diff/1/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/478793002/diff/1/scripts/slave/recipes/chromium_trybot.py#newcode429 scripts/slave/recipes/chromium_trybot.py:429: if match and match.end() == len(name): On 2014/08/15 22:36:23, ...
6 years, 4 months ago (2014-08-15 22:42:10 UTC) #3
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-18 16:00:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/478793002/1
6 years, 4 months ago (2014-08-18 16:00:57 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 16:02:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290265

Powered by Google App Engine
This is Rietveld 408576698