Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 478773002: Make Easy unlock disabled by default for enterprise user. (Closed)

Created:
6 years, 4 months ago by xiyuan
Modified:
6 years, 3 months ago
CC:
chromium-reviews, joaodasilva+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, merkulova
Project:
chromium
Visibility:
Public.

Description

Make Easy unlock disabled by default for enterprise user. BUG=402797 TBR=joaodasilva@chromium.org Committed: https://crrev.com/c65c2f958e810d757ed140bc2ba4b5d730473ff8 Cr-Commit-Position: refs/heads/master@{#293239}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, update comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
xiyuan
6 years, 4 months ago (2014-08-15 19:47:56 UTC) #1
Andrew T Wilson (Slow)
lgtm https://codereview.chromium.org/478773002/diff/1/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc File chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc (right): https://codereview.chromium.org/478773002/diff/1/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc#newcode293 chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc:293: // Default EasyUnlockAllowed is false for managed accounts. ...
6 years, 4 months ago (2014-08-18 13:37:33 UTC) #2
xiyuan
https://codereview.chromium.org/478773002/diff/1/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc File chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc (right): https://codereview.chromium.org/478773002/diff/1/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc#newcode293 chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc:293: // Default EasyUnlockAllowed is false for managed accounts. On ...
6 years, 4 months ago (2014-08-18 16:38:28 UTC) #3
Joao da Silva
joaodasilva@chromium.org changed reviewers: + joaodasilva@chromium.org
6 years, 3 months ago (2014-08-29 08:53:48 UTC) #4
Joao da Silva
This CL may need to be rebased on https://codereview.chromium.org/519643002, if that lands first.
6 years, 3 months ago (2014-08-29 08:53:49 UTC) #5
xiyuan
On 2014/08/29 08:53:49, Joao da Silva wrote: > This CL may need to be rebased ...
6 years, 3 months ago (2014-08-29 15:45:47 UTC) #6
xiyuan
This CL can now land. Joao, tbrring you for policy_templates.json change.
6 years, 3 months ago (2014-09-03 20:53:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/478773002/40001
6 years, 3 months ago (2014-09-03 21:25:18 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as a6268d94a6106deb216cd81983ec88263d32a193
6 years, 3 months ago (2014-09-04 00:41:28 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:07 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c65c2f958e810d757ed140bc2ba4b5d730473ff8
Cr-Commit-Position: refs/heads/master@{#293239}

Powered by Google App Engine
This is Rietveld 408576698