Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 47873012: Fix NullPointerException when connected but no video frame decoded (Closed)

Created:
7 years, 1 month ago by Lambros
Modified:
7 years, 1 month ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix NullPointerException when connected but no video frame decoded This fixes a crash seen when connecting to a host from the Android Chromoting client. The painting code got called before a video frame had been decoded, and tried to dereference a null Bitmap. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/DesktopView.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lambros
7 years, 1 month ago (2013-11-05 01:37:17 UTC) #1
Sergey Ulanov
lgtm
7 years, 1 month ago (2013-11-05 01:40:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/47873012/1
7 years, 1 month ago (2013-11-05 01:49:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/47873012/1
7 years, 1 month ago (2013-11-05 03:04:16 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184827
7 years, 1 month ago (2013-11-05 06:47:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/47873012/1
7 years, 1 month ago (2013-11-05 17:31:46 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 18:00:02 UTC) #7
Message was sent while issue was closed.
Change committed as 233025

Powered by Google App Engine
This is Rietveld 408576698