Issue 47873010: Fix git-cl quoting, yet again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 47873010: Fix git-cl quoting, yet again. (Closed)

Created:
7 years, 1 month ago by M-A Ruel

Modified:
7 years, 1 month ago

Reviewers:
iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Fix git-cl quoting, yet again. Using "%@" will correctly requote quoted arguments. Tested with repro case. The fix in r232184 missed the necessary argument quoting. R=iannucci@chromium.org BUG=314192 BUG=241769 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=232501

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
M	git-cl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	git-try	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pylint	View	1	1 chunk	+1 line, -1 line	0 comments	Download