cc: fix content_to_screen_scale in UpdateTilePriorities.

cc: fix content_to_screen_scale in UpdateTilePriorities.

R=vmpstr@chromium.org, enne@chromium.org, danakj@chromium.org
BUG=403829
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290074

[ernstm, 2014-08-15 17:46:49]

PTAL

[vmpstr, 2014-08-15 17:51:47]

Can you add a few more tests where contents_scale varies and the
ideal_contents_scale varies?

[ernstm, 2014-08-15 20:02:36]

On 2014/08/15 17:51:47, vmpstr wrote:
> Can you add a few more tests where contents_scale varies and the
> ideal_contents_scale varies?

Done. However the problem here was that the test expectations were incorrect,
not that we didn't have coverage. I really think we need better documentation of
the various coordinate spaces to reduce the risk of such errors in the future.

[vmpstr, 2014-08-15 20:11:57]

lgtm

https://codereview.chromium.org/478723002/diff/20001/cc/resources/picture_lay...
File cc/resources/picture_layer_tiling_unittest.cc (right):

https://codereview.chromium.org/478723002/diff/20001/cc/resources/picture_lay...
cc/resources/picture_layer_tiling_unittest.cc:647: tiling =
TestablePictureLayerTiling::Create(0.2f, layer_bounds, &client);
nit: this tiling is exactly the same as the above one; why not sure update tile
priorities on that one?

[ernstm, 2014-08-15 21:29:21]

https://codereview.chromium.org/478723002/diff/20001/cc/resources/picture_lay...
File cc/resources/picture_layer_tiling_unittest.cc (right):

https://codereview.chromium.org/478723002/diff/20001/cc/resources/picture_lay...
cc/resources/picture_layer_tiling_unittest.cc:647: tiling =
TestablePictureLayerTiling::Create(0.2f, layer_bounds, &client);
On 2014/08/15 20:11:57, vmpstr wrote:
> nit: this tiling is exactly the same as the above one; why not sure update
tile
> priorities on that one?

Done.

[enne (OOO), 2014-08-15 21:33:36]

lgtm2

[ernstm, 2014-08-15 21:34:09]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-08-15 21:36:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ernstm@chromium.org/478723002/40001

[commit-bot: I haz the power, 2014-08-16 00:59:28]

Committed patchset #3 (40001) as 290074