Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 478713003: Add BootstrapCheckIn and its test (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@mac_util
Project:
crashpad
Visibility:
Public.

Description

Add BootstrapCheckIn and its test. TEST=util_test Bootstrap.BootstrapCheckIn R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/280c4345c5f7

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase #

Patch Set 3 : Address review feedback #

Total comments: 1

Patch Set 4 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -0 lines) Patch
A util/mach/bootstrap.h View 1 chunk +46 lines, -0 lines 0 comments Download
A util/mach/bootstrap.cc View 1 chunk +88 lines, -0 lines 0 comments Download
A util/mach/bootstrap_test.cc View 1 2 3 1 chunk +134 lines, -0 lines 0 comments Download
M util/util.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mark Mentovai
This depends on https://codereview.chromium.org/473023002/.
6 years, 4 months ago (2014-08-15 17:31:20 UTC) #1
Robert Sesek
https://codereview.chromium.org/478713003/diff/1/util/mach/bootstrap_test.cc File util/mach/bootstrap_test.cc (right): https://codereview.chromium.org/478713003/diff/1/util/mach/bootstrap_test.cc#newcode88 util/mach/bootstrap_test.cc:88: kr = mach_msg(reinterpret_cast<mach_msg_header_t*>(&send_message), Use &send_message.header instead. https://codereview.chromium.org/478713003/diff/1/util/mach/bootstrap_test.cc#newcode103 util/mach/bootstrap_test.cc:103: kr ...
6 years, 4 months ago (2014-08-15 21:53:18 UTC) #2
Mark Mentovai
Good suggestions.
6 years, 4 months ago (2014-08-16 05:51:09 UTC) #3
Mark Mentovai
(We’re 44% done as of this one.)
6 years, 4 months ago (2014-08-16 05:53:11 UTC) #4
Robert Sesek
https://codereview.chromium.org/478713003/diff/40001/util/mach/bootstrap_test.cc File util/mach/bootstrap_test.cc (right): https://codereview.chromium.org/478713003/diff/40001/util/mach/bootstrap_test.cc#newcode88 util/mach/bootstrap_test.cc:88: kr = mach_msg(reinterpret_cast<mach_msg_header_t*>(&send_message.header), You don't need the reinterpret_cast here ...
6 years, 4 months ago (2014-08-18 14:46:28 UTC) #5
Mark Mentovai
Good point.
6 years, 4 months ago (2014-08-18 15:46:04 UTC) #6
Robert Sesek
LGTM
6 years, 4 months ago (2014-08-18 16:11:34 UTC) #7
Mark Mentovai
6 years, 4 months ago (2014-08-19 03:41:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as 280c4345c5f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698