Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 478683002: ES6: Make sure we do not store -0 as the key in Map/Set (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

ES6: Make sure we do not store -0 as the key in Map/Set BUG=v8:3515 LOG=Y R=adamk@chromium.org, dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M src/collection.js View 2 chunks +14 lines, -0 lines 0 comments Download
M test/mjsunit/es6/collections.js View 2 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
arv (Not doing code reviews)
6 years, 4 months ago (2014-08-15 14:43:24 UTC) #1
adamk
lgtm
6 years, 4 months ago (2014-08-15 15:16:28 UTC) #2
arv (Not doing code reviews)
Another option would be to normalize when we get the value out in the iterators.
6 years, 4 months ago (2014-08-15 15:44:23 UTC) #3
Dmitry Lomov (no reviews)
lgtm
6 years, 4 months ago (2014-08-15 16:04:09 UTC) #4
arv (Not doing code reviews)
6 years, 4 months ago (2014-08-19 15:15:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 23204 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698