Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 478623002: Blink-in-JS: Output a correct JS file name and line number when an exception is thrown (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Blink-in-JS: Output a correct JS file name and line number when an exception is thrown Currently there is a bug on V8 APIs on Message objects, and they don't return valid values when they are called at the first time if V8 has a pending exception. We need to call twice in order to get valid values. This is a temporary fix in the Blink side until we fix the V8 side. BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180339

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M Source/bindings/core/v8/PrivateScriptRunner.cpp View 1 1 chunk +7 lines, -2 lines 2 comments Download

Messages

Total messages: 12 (0 generated)
haraken
PTAL
6 years, 4 months ago (2014-08-15 04:51:33 UTC) #1
Jens Widell
LGTM https://codereview.chromium.org/478623002/diff/20001/Source/bindings/core/v8/PrivateScriptRunner.cpp File Source/bindings/core/v8/PrivateScriptRunner.cpp (right): https://codereview.chromium.org/478623002/diff/20001/Source/bindings/core/v8/PrivateScriptRunner.cpp#newcode29 Source/bindings/core/v8/PrivateScriptRunner.cpp:29: // This is a bug of V8. Is ...
6 years, 4 months ago (2014-08-15 04:55:30 UTC) #2
haraken
https://codereview.chromium.org/478623002/diff/20001/Source/bindings/core/v8/PrivateScriptRunner.cpp File Source/bindings/core/v8/PrivateScriptRunner.cpp (right): https://codereview.chromium.org/478623002/diff/20001/Source/bindings/core/v8/PrivateScriptRunner.cpp#newcode29 Source/bindings/core/v8/PrivateScriptRunner.cpp:29: // This is a bug of V8. On 2014/08/15 ...
6 years, 4 months ago (2014-08-15 04:57:23 UTC) #3
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-15 04:57:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/478623002/20001
6 years, 4 months ago (2014-08-15 04:58:26 UTC) #5
haraken
On 2014/08/15 04:57:23, haraken wrote: > https://codereview.chromium.org/478623002/diff/20001/Source/bindings/core/v8/PrivateScriptRunner.cpp > File Source/bindings/core/v8/PrivateScriptRunner.cpp (right): > > https://codereview.chromium.org/478623002/diff/20001/Source/bindings/core/v8/PrivateScriptRunner.cpp#newcode29 > ...
6 years, 4 months ago (2014-08-15 05:20:31 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-15 06:16:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 07:34:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22887)
6 years, 4 months ago (2014-08-15 07:34:34 UTC) #9
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-15 07:35:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/478623002/20001
6 years, 4 months ago (2014-08-15 07:36:00 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 08:09:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180339

Powered by Google App Engine
This is Rietveld 408576698