Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 478563002: Use individual functions to join browser threads. (Closed)

Created:
6 years, 4 months ago by rvargas (doing something else)
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Use individual functions to join browser threads. This enables figuring out which thread is blocking shutdown just by looking at the UI thread stack. BUG=403610 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290015

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix indentation #

Patch Set 3 : Fix iOS warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -26 lines) Patch
M content/browser/browser_main_loop.cc View 1 2 3 chunks +67 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rvargas (doing something else)
6 years, 4 months ago (2014-08-15 01:01:17 UTC) #1
sky
LGTM https://codereview.chromium.org/478563002/diff/1/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/478563002/diff/1/content/browser/browser_main_loop.cc#newcode849 content/browser/browser_main_loop.cc:849: TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:DBThread"); nit: spacing is off in all ...
6 years, 4 months ago (2014-08-15 04:48:01 UTC) #2
rvargas (doing something else)
Thanks! https://codereview.chromium.org/478563002/diff/1/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/478563002/diff/1/content/browser/browser_main_loop.cc#newcode849 content/browser/browser_main_loop.cc:849: TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:DBThread"); On 2014/08/15 04:48:01, sky wrote: > ...
6 years, 4 months ago (2014-08-15 18:01:26 UTC) #3
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 4 months ago (2014-08-15 18:01:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/478563002/40001
6 years, 4 months ago (2014-08-15 18:03:34 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 21:29:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (40001) as 290015

Powered by Google App Engine
This is Rietveld 408576698