Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 478553002: Remove thirdparty/unittest2 from webkitpy and require python2.7. (Closed)

Created:
6 years, 4 months ago by Dirk Pranke
Modified:
6 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Remove thirdparty/unittest2 from webkitpy and require python2.7. This is probably already true in the code base (we mostly require 2.7 for everything except for some things in ChromiumOS), so this is just cleanup. I also fixed a few other nits while touching everything (sorting imports, fixing shebangs and file permissions). R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -2879 lines) Patch
M Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/checkout/scm/detection_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py View 2 chunks +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/config/urls_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/editdistance_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/find_files_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/lru_cache_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/memoized_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/net/buildbot/chromiumbuildbot_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/net/unittestresults_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/newstringio_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/read_checksum_from_png_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/environment_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/executive.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/executive_mock.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/executive_unittest.py View 2 chunks +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/filesystem_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/logtesting.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/logutils_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/outputcapture.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/outputcapture_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/outputtee_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/path_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/profiler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/stack_utils_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/systemhost_mock.py View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/user_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/workspace_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/zipfileset_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/thread/messagepump_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/version_check.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/common/webkitunittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay_unittest.py View 1 chunk +1 line, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/layout_tests_mover_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/models/test_results_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/builders_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/print_layout_test_times_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/print_layout_test_types_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/server_base_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py View 2 chunks +1 line, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checker_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/common_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/jsonchecker_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/png_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/python_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/text_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/xcodeproj_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/xml_unittest.py View 1 chunk +1 line, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/style/error_handlers_unittest.py View 1 chunk +1 line, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/style/filereader_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/filter_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/main_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/optparser_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/patchreader_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/test/finder_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/test/main.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/test/main_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/test/printer.py View 2 chunks +2 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/test/runner.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/test/runner_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/test/skip_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/README.chromium View 2 chunks +0 lines, -21 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/ordered_dict.py View 1 chunk +0 lines, -89 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/__init__.py View 1 chunk +0 lines, -68 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/__main__.py View 1 chunk +0 lines, -10 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/case.py View 1 chunk +0 lines, -1084 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/collector.py View 1 chunk +0 lines, -9 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/compatibility.py View 1 chunk +0 lines, -64 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/loader.py View 1 chunk +0 lines, -322 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/main.py View 1 chunk +0 lines, -241 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/result.py View 1 chunk +0 lines, -183 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/runner.py View 1 chunk +0 lines, -206 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/signals.py View 1 chunk +0 lines, -57 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/suite.py View 1 chunk +0 lines, -287 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/unittest2/util.py View 1 chunk +0 lines, -99 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/bot/commitannouncer_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/queries_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/tool/grammar_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/tool/mocktool_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/w3c/test_converter_unittest.py View 2 chunks +1 line, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 2 chunks +1 line, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/w3c/test_parser_unittest.py View 2 chunks +1 line, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/webgl/update_webgl_conformance_tests_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
6 years, 4 months ago (2014-08-15 00:16:50 UTC) #1
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-15 06:57:15 UTC) #2
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-15 06:57:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/478553002/1
6 years, 4 months ago (2014-08-15 06:58:03 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 07:59:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180338

Powered by Google App Engine
This is Rietveld 408576698