Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2605)

Unified Diff: chrome/browser/media/media_capture_devices_dispatcher.cc

Issue 478543003: Use AudioStreamMonitor to control power save blocking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/media_capture_devices_dispatcher.cc
diff --git a/chrome/browser/media/media_capture_devices_dispatcher.cc b/chrome/browser/media/media_capture_devices_dispatcher.cc
index f007433289ab625e5aaae3384ff788778490cdc0..a10db7abbc4db1978c9db2d7859e7c02ed7a6bb5 100644
--- a/chrome/browser/media/media_capture_devices_dispatcher.cc
+++ b/chrome/browser/media/media_capture_devices_dispatcher.cc
@@ -58,12 +58,6 @@
#include "ash/shell.h"
#endif // defined(OS_CHROMEOS)
-// Only do audio stream monitoring for platforms that use it for the tab media
-// indicator UI or the OOM killer.
-#if !defined(OS_ANDROID) && !defined(OS_IOS)
-#define AUDIO_STREAM_MONITORING
-#include "chrome/browser/media/audio_stream_monitor.h"
-#endif // !defined(OS_ANDROID) && !defined(OS_IOS)
#if defined(ENABLE_EXTENSIONS)
#include "chrome/browser/extensions/api/tab_capture/tab_capture_registry.h"
@@ -196,43 +190,6 @@ scoped_ptr<content::MediaStreamUI> GetDevicesForDesktopCapture(
return ui.Pass();
}
-#if defined(AUDIO_STREAM_MONITORING)
-
-AudioStreamMonitor* AudioStreamMonitorFromRenderFrame(
- int render_process_id,
- int render_frame_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- content::WebContents* const web_contents =
- content::WebContents::FromRenderFrameHost(
- content::RenderFrameHost::FromID(render_process_id, render_frame_id));
- if (!web_contents)
- return NULL;
- return AudioStreamMonitor::FromWebContents(web_contents);
-}
-
-void StartAudioStreamMonitoringOnUIThread(
- int render_process_id,
- int render_frame_id,
- int stream_id,
- const AudioStreamMonitor::ReadPowerAndClipCallback& read_power_callback) {
- AudioStreamMonitor* const audio_stream_monitor =
- AudioStreamMonitorFromRenderFrame(render_process_id, render_frame_id);
- if (audio_stream_monitor)
- audio_stream_monitor->StartMonitoringStream(stream_id, read_power_callback);
-}
-
-void StopAudioStreamMonitoringOnUIThread(
- int render_process_id,
- int render_frame_id,
- int stream_id) {
- AudioStreamMonitor* const audio_stream_monitor =
- AudioStreamMonitorFromRenderFrame(render_process_id, render_frame_id);
- if (audio_stream_monitor)
- audio_stream_monitor->StopMonitoringStream(stream_id);
-}
-
-#endif // defined(AUDIO_STREAM_MONITORING)
-
#if !defined(OS_ANDROID)
// Find browser or app window from a given |web_contents|.
gfx::NativeWindow FindParentWindowForWebContents(
@@ -938,40 +895,6 @@ void MediaCaptureDevicesDispatcher::OnMediaRequestStateChanged(
page_request_id, security_origin, stream_type, state));
}
-void MediaCaptureDevicesDispatcher::OnAudioStreamPlaying(
- int render_process_id,
- int render_frame_id,
- int stream_id,
- const ReadPowerAndClipCallback& read_power_callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-#if defined(AUDIO_STREAM_MONITORING)
- BrowserThread::PostTask(
- BrowserThread::UI,
- FROM_HERE,
- base::Bind(&StartAudioStreamMonitoringOnUIThread,
- render_process_id,
- render_frame_id,
- stream_id,
- read_power_callback));
-#endif
-}
-
-void MediaCaptureDevicesDispatcher::OnAudioStreamStopped(
- int render_process_id,
- int render_frame_id,
- int stream_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-#if defined(AUDIO_STREAM_MONITORING)
- BrowserThread::PostTask(
- BrowserThread::UI,
- FROM_HERE,
- base::Bind(&StopAudioStreamMonitoringOnUIThread,
- render_process_id,
- render_frame_id,
- stream_id));
-#endif
-}
-
void MediaCaptureDevicesDispatcher::OnCreatingAudioStream(
int render_process_id,
int render_frame_id) {
@@ -1070,16 +993,6 @@ void MediaCaptureDevicesDispatcher::OnCreatingAudioStreamOnUIThread(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
FOR_EACH_OBSERVER(Observer, observers_,
OnCreatingAudioStream(render_process_id, render_frame_id));
-#if defined(AUDIO_STREAM_MONITORING)
- content::WebContents* const web_contents =
- content::WebContents::FromRenderFrameHost(
- content::RenderFrameHost::FromID(render_process_id, render_frame_id));
- if (web_contents) {
- // Note: Calling CreateForWebContents() multiple times is valid (see usage
- // info for content::WebContentsUserData).
- AudioStreamMonitor::CreateForWebContents(web_contents);
- }
-#endif
}
bool MediaCaptureDevicesDispatcher::IsDesktopCaptureInProgress() {
@@ -1087,7 +1000,6 @@ bool MediaCaptureDevicesDispatcher::IsDesktopCaptureInProgress() {
return desktop_capture_sessions_.size() > 0;
}
-
void MediaCaptureDevicesDispatcher::SetTestAudioCaptureDevices(
const MediaStreamDevices& devices) {
test_audio_devices_ = devices;

Powered by Google App Engine
This is Rietveld 408576698