Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 47853004: IDL Compiler: Make [PerWorldBindings] work with [DoNotCheckSecurity] (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, lgombos
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

IDL Compiler: Make [PerWorldBindings] work with [DoNotCheckSecurity] Update the perl bindings generator so that using [PerWorldBindings] in combination with [DoNotCheckSecurity] will actually do what the user expects. Previously, it generated half of the necessary *ForMainWorld() static functions and never used them. This affects at least the generated code for the assign() and replace() operations in Location.idl. Kuddos to Laszlo Gombos for enabling the warnings and notifying me that we had unused functions in the generated bindings. R=haraken BUG=312287 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160890

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -6 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 5 chunks +22 lines, -6 lines 0 comments Download
M Source/bindings/tests/idls/TestActiveDOMObject.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObject.cpp View 3 chunks +127 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
Please be extra careful reviewing as I am not very familiar with PerWorldBindings.
7 years, 1 month ago (2013-10-29 21:55:53 UTC) #1
haraken
LGTM.
7 years, 1 month ago (2013-10-30 00:14:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/47853004/1
7 years, 1 month ago (2013-10-30 00:52:01 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 02:34:41 UTC) #4
Message was sent while issue was closed.
Change committed as 160890

Powered by Google App Engine
This is Rietveld 408576698