Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 478523002: mojo events: Add |screen_location| to LocationData. (Closed)

Created:
6 years, 4 months ago by Elliot Glaysher
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

mojo events: Add |screen_location| to located events. Building blink events requires more data than we currently pass through mojo::EventPtr. That data is available on the side that has the base::NativeEvent, so we now send both the view relative location and the system location through. This also lets us drop a DEPS on "ui/events" from the html viewer. Eventually, we'll want our own event types, but this works for now. BUG=403514 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290077

Patch Set 1 #

Patch Set 2 : Remove the depencency on ui/events from html_viewer entirely. #

Patch Set 3 : Fix windows compile, and make work. #

Patch Set 4 : Change windows capitalization. #

Patch Set 5 : General patch cleanup. #

Patch Set 6 : Fix crash observed locally because of synthesized aura events. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -153 lines) Patch
M mojo/examples/pepper_container_app/pepper_container_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/sample_app/gles2_client_impl.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_services.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/html_viewer/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/html_viewer/blink_input_events_type_converters.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/html_viewer/blink_input_events_type_converters.cc View 1 2 3 4 5 5 chunks +52 lines, -26 lines 0 comments Download
M mojo/services/public/cpp/input_events/lib/input_events_type_converters.cc View 1 2 6 chunks +19 lines, -6 lines 0 comments Download
A + mojo/services/public/interfaces/input_events/input_event_constants.mojom View 1 2 3 4 2 chunks +20 lines, -38 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_events.mojom View 2 chunks +7 lines, -65 lines 0 comments Download
M ui/events/win/events_win.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
6 years, 4 months ago (2014-08-15 20:01:29 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 4 months ago (2014-08-15 21:41:15 UTC) #2
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 4 months ago (2014-08-15 21:47:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/478523002/100001
6 years, 4 months ago (2014-08-15 21:49:54 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 01:11:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 (100001) as 290077

Powered by Google App Engine
This is Rietveld 408576698