Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 478493002: Add ability to active multiple devices via the audio API. (Closed)

Created:
6 years, 4 months ago by jennyz
Modified:
6 years, 4 months ago
Reviewers:
rkc, hychao, zel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add ability to active multiple devices via the audio API. Add the ability to the audio API to activate more than one audio device at a time. This is currently accomplished via a hack and when getting device info via audio.getInfo, only one device will show up as active. This will allow us to active multiple microphones and multiple speakers though. I've also made couple of changes to OWNERS files so we don't need to keep chasing rubberstamps for audio changes. This is patched from rkc@'s original cl: https://codereview.chromium.org/460113003/ BUG=397664 TBR=asargent Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -6 lines) Patch
A + chrome/browser/extensions/api/audio/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/extensions/api/audio/audio_service_chromeos.cc View 2 chunks +50 lines, -7 lines 0 comments Download
M chromeos/dbus/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/dbus/cras_audio_client.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chromeos/dbus/cras_audio_client.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chromeos/dbus/cras_audio_client_stub_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/cras_audio_client_stub_impl.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jennyz
Since rkc@ is not available due to his transferring to NYC, I 've taken his ...
6 years, 4 months ago (2014-08-14 21:55:19 UTC) #1
jennyz
6 years, 4 months ago (2014-08-14 21:56:20 UTC) #2
zel
lgtm
6 years, 4 months ago (2014-08-14 21:57:55 UTC) #3
hychao
lgtm
6 years, 4 months ago (2014-08-15 07:19:37 UTC) #4
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 4 months ago (2014-08-15 16:15:55 UTC) #5
jennyz
The CQ bit was unchecked by jennyz@chromium.org
6 years, 4 months ago (2014-08-15 16:16:37 UTC) #6
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 4 months ago (2014-08-15 16:44:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/478493002/1
6 years, 4 months ago (2014-08-15 16:47:52 UTC) #8
rkc
lgtm Thanks for taking this over Jenny!
6 years, 4 months ago (2014-08-15 16:56:32 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-15 18:22:17 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 18:41:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 289951

Powered by Google App Engine
This is Rietveld 408576698