Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 478453002: Remove PersonalAutofillPopulator for Android. (Closed)

Created:
6 years, 4 months ago by aurimas (slooooooooow)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove PersonalAutofillPopulator for Android. BUG=403872 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289993

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits #

Patch Set 3 : Rebase #

Patch Set 4 : Update AutofillManagerTest expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1174 lines) Patch
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill.gypi View 3 chunks +0 lines, -43 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D components/autofill/core/browser/android/auxiliary_profile_loader_android.h View 1 chunk +0 lines, -75 lines 0 comments Download
D components/autofill/core/browser/android/auxiliary_profile_loader_android.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D components/autofill/core/browser/android/auxiliary_profile_unittest_android.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D components/autofill/core/browser/android/auxiliary_profiles_android.h View 1 chunk +0 lines, -54 lines 0 comments Download
D components/autofill/core/browser/android/auxiliary_profiles_android.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D components/autofill/core/browser/android/component_jni_registrar.h View 1 chunk +0 lines, -18 lines 0 comments Download
D components/autofill/core/browser/android/component_jni_registrar.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D components/autofill/core/browser/android/java/src/org/chromium/components/browser/autofill/PersonalAutofillPopulator.java View 1 chunk +0 lines, -304 lines 0 comments Download
D components/autofill/core/browser/android/personal_data_manager_android.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D components/autofill/core/browser/android/test_auxiliary_profile_loader_android.h View 1 chunk +0 lines, -74 lines 0 comments Download
D components/autofill/core/browser/android/test_auxiliary_profile_loader_android.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
aurimas (slooooooooow)
isherman: PTAL.
6 years, 4 months ago (2014-08-14 20:17:39 UTC) #1
Ilya Sherman
Please update the logic for registering the pref [1] as well. Do you know why ...
6 years, 4 months ago (2014-08-14 21:18:30 UTC) #2
aurimas (slooooooooow)
Updated the bug with details about why this never launched. https://chromiumcodereview.appspot.com/478453002/diff/1/components/autofill/core/browser/personal_data_manager.cc File components/autofill/core/browser/personal_data_manager.cc (right): https://chromiumcodereview.appspot.com/478453002/diff/1/components/autofill/core/browser/personal_data_manager.cc#newcode930 ...
6 years, 4 months ago (2014-08-14 21:45:10 UTC) #3
aurimas (slooooooooow)
yfriedman@chromium.org: Please review changes in chrome/browser/android/chrome_jni_registrar.cc
6 years, 4 months ago (2014-08-14 21:47:21 UTC) #4
Ilya Sherman
LGTM, thanks.
6 years, 4 months ago (2014-08-14 21:51:01 UTC) #5
aurimas (slooooooooow)
thestig: please take a look at chrome/chrome.gypi
6 years, 4 months ago (2014-08-14 22:15:37 UTC) #6
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-14 22:37:16 UTC) #7
Yaron
chrome/browser/android/chrome_jni_registrar.cc lgtm
6 years, 4 months ago (2014-08-14 22:54:07 UTC) #8
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 4 months ago (2014-08-14 22:57:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/478453002/20001
6 years, 4 months ago (2014-08-14 23:00:40 UTC) #10
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 4 months ago (2014-08-15 00:46:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/478453002/40001
6 years, 4 months ago (2014-08-15 00:50:56 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 06:56:42 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 08:16:11 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/6019)
6 years, 4 months ago (2014-08-15 08:16:12 UTC) #15
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 4 months ago (2014-08-15 16:30:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/478453002/60001
6 years, 4 months ago (2014-08-15 16:32:19 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 20:09:53 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (60001) as 289993

Powered by Google App Engine
This is Rietveld 408576698