Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 478403002: Fix HLS playback on Galaxy S4 (Closed)

Created:
6 years, 4 months ago by qinmin
Modified:
5 years, 11 months ago
Reviewers:
xhwang
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix HLS playback on Galaxy S4 Galaxy S4 requires a surface texture in order for the media player to report correct video size. So bind a texture to MediaPlayer whenever the video is HLS BUG=400145 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291184

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 3 chunks +12 lines, -2 lines 1 comment Download

Messages

Total messages: 16 (0 generated)
qinmin
PTAL
6 years, 4 months ago (2014-08-18 18:22:21 UTC) #1
xhwang
lgtm
6 years, 4 months ago (2014-08-20 22:48:49 UTC) #2
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 4 months ago (2014-08-20 22:50:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/478403002/1
6 years, 4 months ago (2014-08-20 22:52:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 23:56:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 00:00:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55303) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/8059)
6 years, 4 months ago (2014-08-21 00:00:02 UTC) #7
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 4 months ago (2014-08-21 01:15:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/478403002/1
6 years, 4 months ago (2014-08-21 01:16:27 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 01:20:12 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 01:23:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55418)
6 years, 4 months ago (2014-08-21 01:23:20 UTC) #12
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 4 months ago (2014-08-21 17:08:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/478403002/1
6 years, 4 months ago (2014-08-21 17:10:25 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (1) as 291184
6 years, 4 months ago (2014-08-21 21:11:07 UTC) #15
miroslav
5 years, 11 months ago (2015-01-13 18:47:17 UTC) #16
Message was sent while issue was closed.
https://codereview.chromium.org/478403002/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/478403002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:1737: return
!mime.compare("application/x-mpegurl");
How about vnd.apple.mpegURL?

Powered by Google App Engine
This is Rietveld 408576698