fpdfsdk/include/fsdk_baseannot.h - Issue 478353002: Fix tzHour usage on systems where char is unsigned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/fsdk_baseannot.h

Issue 478353002: Fix tzHour usage on systems where char is unsigned. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: different Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/fsdk_baseannot.h

diff --git a/fpdfsdk/include/fsdk_baseannot.h b/fpdfsdk/include/fsdk_baseannot.h

index 50a6e1e2e55c9fcbc4ea4dfcdc60fe470f7e70c5..dfb3a5512a5c7656b4254acc727f886300f84f0f 100644

--- a/fpdfsdk/include/fsdk_baseannot.h

+++ b/fpdfsdk/include/fsdk_baseannot.h

@@ -53,7 +53,7 @@ public:

FX_BYTE hour;

FX_BYTE minute;

FX_BYTE second;

- FX_CHAR tzHour;

+ signed char tzHour;

Bo Xu 2014/08/18 17:57:42 Maybe we can use FX_INT8 here?

Nico 2014/08/18 18:13:48 Oh, that's even better. Done, thanks!

FX_BYTE tzMinute;

}dt;

};

« no previous file with comments | « no previous file | no next file » | no next file with comments »