Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 478353002: Fix tzHour usage on systems where char is unsigned. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Fix tzHour usage on systems where char is unsigned. BUG=chromium:395832 R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/635e82e

Patch Set 1 #

Patch Set 2 : different #

Total comments: 2

Patch Set 3 : better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M fpdfsdk/include/fsdk_baseannot.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
See patch set 1 for a different type. Patch set 2 seems nicer though.
6 years, 4 months ago (2014-08-18 16:45:25 UTC) #1
Nico
On 2014/08/18 16:45:25, Nico (very away) wrote: > See patch set 1 for a different ...
6 years, 4 months ago (2014-08-18 16:50:46 UTC) #2
Nico
Sorry, rietveld keeps suggesting bo_xu@chromium.org :-(
6 years, 4 months ago (2014-08-18 16:51:10 UTC) #3
Bo Xu
https://codereview.chromium.org/478353002/diff/20001/fpdfsdk/include/fsdk_baseannot.h File fpdfsdk/include/fsdk_baseannot.h (right): https://codereview.chromium.org/478353002/diff/20001/fpdfsdk/include/fsdk_baseannot.h#newcode56 fpdfsdk/include/fsdk_baseannot.h:56: signed char tzHour; Maybe we can use FX_INT8 here?
6 years, 4 months ago (2014-08-18 17:57:42 UTC) #4
Nico
https://codereview.chromium.org/478353002/diff/20001/fpdfsdk/include/fsdk_baseannot.h File fpdfsdk/include/fsdk_baseannot.h (right): https://codereview.chromium.org/478353002/diff/20001/fpdfsdk/include/fsdk_baseannot.h#newcode56 fpdfsdk/include/fsdk_baseannot.h:56: signed char tzHour; On 2014/08/18 17:57:42, Bo Xu wrote: ...
6 years, 4 months ago (2014-08-18 18:13:48 UTC) #5
Bo Xu
On 2014/08/18 18:13:48, Nico (very away) wrote: > https://codereview.chromium.org/478353002/diff/20001/fpdfsdk/include/fsdk_baseannot.h > File fpdfsdk/include/fsdk_baseannot.h (right): > > ...
6 years, 4 months ago (2014-08-18 18:14:48 UTC) #6
Nico
6 years, 4 months ago (2014-08-18 18:17:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as 635e82e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698