Source/core/rendering/compositing/CompositingInputsUpdater.cpp - Issue 478333002: hasDescendantWithBlendMode should not be propagated outside the current stacking context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/CompositingInputsUpdater.cpp

Issue 478333002: hasDescendantWithBlendMode should not be propagated outside the current stacking context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/compositing/CompositingInputsUpdater.cpp

diff --git a/Source/core/rendering/compositing/CompositingInputsUpdater.cpp b/Source/core/rendering/compositing/CompositingInputsUpdater.cpp

index c73e4b63219bd4afeea9b825404fcf8164850dd2..1803c37198c5c858e5f1e330577e08bc33ffd617 100644

--- a/Source/core/rendering/compositing/CompositingInputsUpdater.cpp

+++ b/Source/core/rendering/compositing/CompositingInputsUpdater.cpp

@@ -174,7 +174,7 @@ void CompositingInputsUpdater::updateRecursive(RenderLayer* layer, UpdateType up

updateRecursive(child, updateType, info);

descendantProperties.hasDescendantWithClipPath |= child->hasDescendantWithClipPath() || child->renderer()->hasClipPath();

- descendantProperties.hasDescendantWithBlendMode |= child->hasDescendantWithBlendMode() || child->renderer()->hasBlendMode();

+ descendantProperties.hasNonIsolatedDescendantWithBlendMode |= (!child->stackingNode()->isStackingContext() && child->hasNonIsolatedDescendantWithBlendMode()) || child->renderer()->hasBlendMode();

}

layer->updateDescendantDependentCompositingInputs(descendantProperties);

« no previous file with comments | « Source/core/rendering/RenderLayer.h ('k') | no next file » | no next file with comments »